Skip to content

Migrate DialogSelectViewHolderFactory to compose #2906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LZRS wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Migrate DialogSelectViewHolderFactory to compose #2906

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d29166c
Migrate QuestionnaireItemDialogSelectViewHolderFactory to compose
LZRS Nov 10, 2025
2e21dbc
Merge remote-tracking branch 'upstream/master' into sdc-compose-dialo…
LZRS Nov 25, 2025
f1786cb
Fix failing tests for dialog select
LZRS Nov 26, 2025
c253535
Clean up and remove .xml layout files
LZRS Nov 27, 2025
85fa203
Fix failing tests for small screen sizes
LZRS Nov 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1,040 changes: 1,040 additions & 0 deletions .../com/google/android/fhir/datacapture/test/views/DialogMultiSelectViewHolderFactoryTest.kt
View file
Open in desktop

Large diffs are not rendered by default.

843 changes: 0 additions & 843 deletions ...datacapture/test/views/QuestionnaireItemDialogMultiSelectViewHolderFactoryEspressoTest.kt
View file
Open in desktop

This file was deleted.

176 changes: 0 additions & 176 deletions .../fhir/datacapture/test/views/QuestionnaireItemMultiSelectHolderFactoryInstrumentedTest.kt
View file
Open in desktop

This file was deleted.

4 changes: 2 additions & 2 deletions datacapture/src/main/java/com/google/android/fhir/datacapture/QuestionnaireLists.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ import com.google.android.fhir.datacapture.views.factories.BooleanChoiceViewHold
import com.google.android.fhir.datacapture.views.factories.CheckBoxGroupViewHolderFactory
import com.google.android.fhir.datacapture.views.factories.DatePickerViewHolderFactory
import com.google.android.fhir.datacapture.views.factories.DateTimePickerViewHolderFactory
import com.google.android.fhir.datacapture.views.factories.DialogSelectViewHolderFactory
import com.google.android.fhir.datacapture.views.factories.DisplayViewHolderFactory
import com.google.android.fhir.datacapture.views.factories.DropDownViewHolderFactory
import com.google.android.fhir.datacapture.views.factories.EditTextDecimalViewHolderFactory
Expand All @@ -51,7 +52,6 @@ import com.google.android.fhir.datacapture.views.factories.EditTextMultiLineView
import com.google.android.fhir.datacapture.views.factories.EditTextSingleLineViewHolderFactory
import com.google.android.fhir.datacapture.views.factories.GroupViewHolderFactory
import com.google.android.fhir.datacapture.views.factories.QuantityViewHolderFactory
import com.google.android.fhir.datacapture.views.factories.QuestionnaireItemDialogSelectViewHolderFactory
import com.google.android.fhir.datacapture.views.factories.QuestionnaireItemViewHolder
import com.google.android.fhir.datacapture.views.factories.QuestionnaireItemViewHolderFactory
import com.google.android.fhir.datacapture.views.factories.RadioGroupViewHolderFactory
Expand Down Expand Up @@ -282,7 +282,7 @@ private fun getQuestionnaireItemViewHolderFactory(
QuestionnaireViewHolderType.QUANTITY -> QuantityViewHolderFactory
QuestionnaireViewHolderType.CHECK_BOX_GROUP -> CheckBoxGroupViewHolderFactory
QuestionnaireViewHolderType.AUTO_COMPLETE -> AutoCompleteViewHolderFactory
QuestionnaireViewHolderType.DIALOG_SELECT -> QuestionnaireItemDialogSelectViewHolderFactory
QuestionnaireViewHolderType.DIALOG_SELECT -> DialogSelectViewHolderFactory
QuestionnaireViewHolderType.SLIDER -> SliderViewHolderFactory
QuestionnaireViewHolderType.PHONE_NUMBER -> PhoneNumberViewHolderFactory
QuestionnaireViewHolderType.ATTACHMENT -> AttachmentViewHolderFactory
Expand Down
Loading
Loading