Fix - deprecated warning for datetime.utcnow() with Python >= 3.12 #792
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barbibulle
requested changes
Sep 28, 2025
bumble/snoop.py
Outdated
| The keyword args that may be referenced by the string pattern are: | ||
| now: the value of `datetime.now()` | ||
| utcnow: the value of `datetime.utcnow()` | ||
| utcnow: the value of 'datetime.now(tz=datetime.timezone.utc)' |
There was a problem hiding this comment.
It would be best to keep the backquotes here instead of regular quotes.
barbibulle
reviewed
Sep 28, 2025
| int( | ||
| ( | ||
| datetime.datetime.now(tz=datetime.timezone.utc) | ||
| - self.TIMESTAMP_ANCHOR |
There was a problem hiding this comment.
I think that TIMESTAMP_ANCHOR would need to be updated as well, to be a timestamp with an explicit UTC timezone.
There was a problem hiding this comment.
update
I think that
TIMESTAMP_ANCHORwould need to be updated as well, to be a timestamp with an explicit UTC timezone.
updated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced
datetime.utcnow()withdatetime.now(tz=datetime.timezone.utc)to fix following deprecated warning:Use timezone-aware objects to represent datetimes in UTC; e.g. by calling .now(datetime.timezone.utc)This warning can be very annoying when running pytest tests with enabled HCI snooping.