Upgrade runner and package architectures

[ChadKillingsworth]

• Supports arm64 architectures on both MacOS and Linux. Only arm64 MacOS builds are now supported.
• Renames the google-closure-compiler-osx package to google-closure-compiler-macos
• Updates NodeJS to match the current supported version set
• Updates UPX version

[sbc100]

Is there some way to avoid dropping support for x86_64 MacOS machines? I think we are going to have to continue to support running emscirpten on x86_64 mac for a while now. See emscripten-core/emsdk#1548.

[ChadKillingsworth]

I don't think we've had x86 support for quite some time. The build runner was set to runs-on: macos-latest and according to the docs not since MacOS 13 has intel chipsets been supported. This change was basically just referencing reality.

[sbc100]

Github actions might not support x86 macOS by default, but it seems there are enough x86 MacOS devices in the wild that we should continue to support them. Especially since there is no reverse-Rosetta as a fallback, so instead or running binary in emulation mode such users will just see a hard crash.

Also, I'm not sure what you mean by "I don't think we've had x86 support for quite some time", that current npm release of closure compiler (the one that folks are using today) includes an x86 macOS binary.

[ChadKillingsworth]

that current npm release of closure compiler (the one that folks are using today) includes an x86 macOS binary.

But are you sure it actually works on an x86 intel Mac? I know the package.json says it does, but I believe the binary was built on an arm processor and will only execute on an ARM Mac.

[ChadKillingsworth]

With this change, Intel Mac users will fall back to utilizing the Java version. That seems very appropriate given that this is now a minority of Macs.

[sbc100]

The current release (which was built 1 year, and which we ship in emscripten) does have an x86 binary in it :

$ file node_modules/google-closure-compiler-osx/compiler 
node_modules/google-closure-compiler-osx/compiler: Mach-O 64-bit executable x86_64

I guess it just happens to run on arm machines due to Rosetta.

[sbc100]

With this change, Intel Mac users will fall back to utilizing the Java version. That seems very appropriate given that this is now a minority of Macs.

True, that seems like one option. However it does require those users to install the JVM, which I'm not sure ships enabled by default with macOS. Including/bundling the JVM as part of the emscripten SDK is possible, might be possible but seems like lot extra compexity/size just to run this one binary.

[ChadKillingsworth]

There's definitely an effort/reward piece to this too. This is an open-source project and keeping up with multiple npm packages and the build jobs takes effort.

[sbc100]

Would you be interesting in contributions in this area? I will look into how smooth/feasible the Java fallback is for x86 users, but it may be worth our time (emscripten) to help out here instead of relying on Java.

[ChadKillingsworth]

Would you be interesting in contributions in this area?

Absolutely - as long as it also comes with helping keeping up with general runner maintenance (actions need version bumps, base runner images need updated, node versions have to be bumped, etc).