Bug fixes to WebRTC externs #4228
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The compiler's definition of this function requires one or more streams, and differs from references [1][2] which require zero or more. Code using addTrack(track) is valid, tested in Chromium 113.0.5659.0 and later. [1] https://developer.mozilla.org/en-US/docs/Web/API/RTCPeerConnection/addTrack [2] https://www.w3.org/TR/webrtc/#ref-for-dom-rtcpeerconnection-addtrack-8 Fixes: google#4071
This spec [1] is consistent with the MDN documentation [2] in this regard. [1] https://www.w3.org/TR/webrtc/#rtctrackevent [2] https://developer.mozilla.org/en-US/docs/Web/API/RTCTrackEvent
The Mozilla documentation [1][2] states this parameter is not read-only and it this behaviour is useful for the purpose of replacing the buffer with another one. This matches the information in [3][4]. [1] https://developer.mozilla.org/en-US/docs/Web/API/RTCEncodedAudioFrame [2] https://developer.mozilla.org/en-US/docs/Web/API/RTCEncodedVideoFrame [3] https://www.w3.org/TR/webrtc-encoded-transform/#RTCEncodedAudioFrame-members [4] https://www.w3.org/TR/webrtc-encoded-transform/#RTCEncodedVideoFrame-members
rishipal
added
triage-done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One is issue #4071, I'm unable to find an issue for the others but the commit message contains an explanation for each fix.