Refactor generate_fields.#1190
Merged
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_930147208
branch
6 times, most recently
from
adb049b to
60d2cb7
Compare
`generate_fields` was a monolithic function that did a lot. This introduces a struct `AdtFieldGenerator` to hold the shared state and breaks that function out into multiple methods. No behavior change is expected, and I cannot explain the golden change. Some further refactoring can be done but it'll involve refacotring in other parts of the code and this is already a big change. PiperOrigin-RevId: 932571510
copybara-service
Bot
force-pushed
the
test_930147208
branch
from
60d2cb7 to
f492ac4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor generate_fields.
generate_fieldswas a monolithic function that did a lot. Thisintroduces a struct
AdtFieldGeneratorto hold the shared state andbreaks that function out into multiple methods.
No behavior change is expected, and I cannot explain the golden change.
Some further refactoring can be done but it'll involve refacotring in
other parts of the code and this is already a big change.