gltfio: allow for multiple color attributes #8462
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poweifeng
force-pushed
the
pf/gltfio-fix-color-attributes
branch
from
4705591 to
c254890
Compare
libs/gltfio/src/AssetLoader.cpp
Outdated
Comment on lines
363
to
366
| if (mDummyBufferObject) { | ||
| mEngine.destroy(mDummyBufferObject); | ||
| } | ||
| } |
There was a problem hiding this comment.
was this just leaking before? Also is it safe to do this in the FAssetLoader dtor -- i.e. is it guaranteed to be called on the correct thread?
There was a problem hiding this comment.
actually, I misread the code. It was properly cleaned up before. I removed all the dummy buffer changes.
We are not correctly handling gltf models with multiple color attributes. Filament doesn't allow for more than one color attribute. So we just set the additional attributes as VertexAttribute::CUSOM(N). Fixes #8396
poweifeng
force-pushed
the
pf/gltfio-fix-color-attributes
branch
from
c254890 to
66d3928
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are not correctly handling gltf models with multiple color attributes. Filament doesn't allow for more than one color attribute. So we just set the additional attributes as VertexAttribute::CUSOM(N).
Also properly clean up dummy buffer.
Fixes #8396