Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register all log files with cleaner #1086

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

mturnock
Copy link

Ensures logs at other verbosity levels are cleaned up even if they are not logged

@codecov-commenter
Copy link

codecov-commenter commented Mar 12, 2024

Codecov Report

Attention: Patch coverage is 89.85507% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 60.72%. Comparing base (31429d8) to head (b52e058).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1086      +/-   ##
==========================================
+ Coverage   60.52%   60.72%   +0.19%     
==========================================
  Files          19       19              
  Lines        2574     2607      +33     
  Branches      917      933      +16     
==========================================
+ Hits         1558     1583      +25     
- Misses        676      687      +11     
+ Partials      340      337       -3     
Files Coverage Δ
src/logging.cc 68.57% <89.85%> (+0.17%) ⬆️

@mturnock
Copy link
Author

This implements the suggested registration approach. Any comments?

@sergiud
Copy link
Collaborator

sergiud commented Mar 13, 2024

Thanks for submitting the revised PR!

Unfortunately, I need some time to review the changes in detail.

Ensures logs at other verbosity levels are cleaned up even if they are not logged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants