Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LOG_TO_SINK_IF and DLOG_TO_SINK #1117

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sukanth2705
Copy link

@sukanth2705 sukanth2705 commented Jul 31, 2024

Added LOG_TO_SINK_IF and DLOG_TO_SINK in logging.h

This PR closes #568

Copy link

google-cla bot commented Jul 31, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@sukanth2705 sukanth2705 marked this pull request as ready for review July 31, 2024 08:32
@sukanth2705
Copy link
Author

@sergiud Can u take a look?

Copy link
Collaborator

@sergiud sergiud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Please use the new macros in a test to avoid compile-time errors and briefly describe them here.

@codecov-commenter
Copy link

codecov-commenter commented Aug 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.03%. Comparing base (570c7e4) to head (18bbf15).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1117      +/-   ##
==========================================
- Coverage   64.04%   64.03%   -0.02%     
==========================================
  Files          20       20              
  Lines        2578     2580       +2     
  Branches      898      908      +10     
==========================================
+ Hits         1651     1652       +1     
- Misses        662      663       +1     
  Partials      265      265              
Files Coverage Δ
src/glog/logging.h 83.60% <ø> (ø)

... and 1 file with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add LOG_TO_SINK_IF and DLOG_TO_SINK
3 participants