[WIP] Add ability to create multiple tags in one call. #2132
Conversation
Fixes google#1797 Signed-off-by: Eric Smalling <[email protected]>
pkg/crane/tag.go
Outdated
| // Tag adds tag to the remote img. | ||
| func Tag(img, tag string, opt ...Option) error { | ||
| // Tag adds one or more tags to the remote img. | ||
| func Tag(img string, tags any, opt ...Option) error { |
There was a problem hiding this comment.
This is an API breaking change.
If we wanted to avoid this, we could maybe have WithTags(string...) Option, but even that might be kind of annoying.
There was a problem hiding this comment.
good catch. I'll work on this
There was a problem hiding this comment.
New version pushed, let me know what you think.
| // Apply each tag | ||
| for i, tag := range tagList { | ||
| dst := ref.Context().Tag(tag) | ||
| if err := remote.Tag(dst, desc, o.Remote...); err != nil { |
There was a problem hiding this comment.
One nice thing about tagging being done on only one tag is that we know exactly whether to continue or fail when tagging fails. When there are multiple tags requested and one fails, should we:
- fail right away
- try to undo the successful tags?
- keep trying to apply more tags?
I don't have a super strong opinion, and failing right away like this is probably fine, but with single-tagging it's up to the caller what to do. I guess it's still up to them, and they could just keep using single-tagging.
There was a problem hiding this comment.
yeah, that's what I was thinking about here
Signed-off-by: Eric Smalling <[email protected]>
Fixes #1797