Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use go 1.22 to allow building with go1.18 #3432

Closed
wants to merge 1 commit into from
Closed

Use go 1.22 to allow building with go1.18 #3432

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/google/go-github/v68

go 1.22.0
go 1.22

require (
github.com/google/go-cmp v0.6.0
Expand Down
2 changes: 1 addition & 1 deletion script/generate.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,6 @@ for dir in $MOD_DIRS; do
(
cd "$dir"
go generate ./...
GOTOOLCHAIN="go1.22+auto" go mod tidy
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#3428 reverted to fix the error while running ./script/lint.sh:

linting tools
validating openapi_operations.yaml
validating generated files
go: downloading go1.22 (linux/amd64)
go: invalid toolchain: go1.22 is a language version but not a toolchain version (go1.22.x)
failed validating generated files

go mod tidy
)
done
Loading