Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Fix #3720 #6218

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

PR: Fix #3720 #6218

wants to merge 7 commits into from

Conversation

u7305790
Copy link

Add methods corresponding to the requirements in #3720 and tests

@google-cla
Copy link

google-cla bot commented Oct 17, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@u7305790
Copy link
Author

PR: Fix #3720

Update:
indexOf(byte[] array, byte target, int fromIndex) [Byte.java]
indexOf(byte[] array, byte[] target, int fromIndex) [Byte.java]
lastIndexOf(byte[] array, byte target, int fromIndex) [Byte.java]
lastIndexOf(byte[] array, byte[] target, int fromIndex) [Byte.java]

These 4 methods are written strictly according to the requirements of the issue #3720.

Unit Tests written:
testIndexOf_arrayTarget_fromIndex() [ByteTest.java]
testIndexOf_fromIndex() [ByteTest.java]
testLastIndexOf_fromIndex() [ByteTest.java]

These tests try to cover a case coverage as comprehensively as possible.

I think the requirements of this issue have been met. If there are extra requirements or bugs exists, please just comment here.

Thanks for reviewing it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants