added lines() in LineReader #6308
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SplotyCode
reviewed
Jan 25, 2023
| } | ||
| @Override | ||
| public String next() { | ||
| if (!nextLine.equals("") || hasNext()) { |
There was a problem hiding this comment.
The !nextLine.equals("") condition should be already covered by the hasNext() right?
| */ | ||
| public Stream<String> lines() | ||
| { | ||
| Iterator<String> iterator = new Iterator<String>() { |
There was a problem hiding this comment.
Perhaps using the AbstractIterator would make the logic quite a bit simpler
| @@ -14,19 +14,29 @@ | |||
|
|
|||
| package com.google.common.io; | |||
|
|
|||
| import static com.google.common.base.Preconditions.checkNotNull; | |||
There was a problem hiding this comment.
Did you chance the import order accidentally? Google Java Styleguide
SplotyCode
reviewed
Jan 29, 2023
| @@ -121,6 +127,13 @@ private static List<String> readUsingReader(String input, int chunk, boolean asR | |||
| return lines; | |||
| } | |||
|
|
|||
| private static Stream<String> readUsingReaderGetLines(String input, int chunk, boolean asReader) { | |||
| Readable readable = | |||
| asReader ? getChunkedReader(input, chunk) : getChunkedReadable(input, chunk); | |||
There was a problem hiding this comment.
When looking through the code base, this is the way they split the ternary operator
Suggested change
| asReader ? getChunkedReader(input, chunk) : getChunkedReadable(input, chunk); | |
| Readable readable = asReader | |
| ? getChunkedReader(input, chunk) | |
| : getChunkedReadable(input, chunk); |
There was a problem hiding this comment.
I referred this function readUsingReader.
| * this {@code LineReader}. | ||
| * | ||
| * @return a {@code Stream<String>} providing the lines of text | ||
| * described by this {@code LineReader} |
There was a problem hiding this comment.
I believe the JavaDoc should:
- state that the caller is in charge of closing the Stream (probably also annotate the method with @MustBeClosed)
- mention the fact that we throw UncheckedIOException
- explain how we define a line (maybe just mention that a line has the same semantics as in LineReader#lines)
ayushsinghal90
force-pushed
the
issue_6067
branch
2 times, most recently
from
05eadd3
to
97bd7a5
Compare
ayushsinghal90
force-pushed
the
issue_6067
branch
from
97bd7a5
to
0db22de
Compare
SplotyCode
reviewed
Jan 31, 2023
| * | ||
| * @return a {@code Stream<String>} providing the lines of text | ||
| * described by this {@code LineReader} | ||
| * @throws UncheckedIOException if an I/O error occurs. |
There was a problem hiding this comment.
The method itself does not throw UncheckedIOException right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #6067