Ignore sysmsg tgkill errors if the sysmsg thread is already dead.
#11658
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
This can happen in case the entire sandbox is being torn down unceremoniously such that the order of who dies first isn't controlled for. I am not sure if this should also set `sc.subprocess.dead`, as the `tgkill` seems to be specifically about a sysmsg thread associated with this subprocess, not about the subprocess itself. PiperOrigin-RevId: 750384169
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore sysmsg
tgkillerrors if the sysmsg thread is already dead.This can happen in case the entire sandbox is being torn down
unceremoniously such that the order of who dies first isn't controlled
for.
I am not sure if this should also set
sc.subprocess.dead, as thetgkillseems to be specifically about a sysmsg thread associatedwith this subprocess, not about the subprocess itself.