Skip to content

Add a non-gpu workload test for pod snapshots. #11858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add a non-gpu workload test for pod snapshots. #11858

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions test/kubernetes/testcluster/objects.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -444,15 +444,17 @@ func addToleration(podSpec *v13.PodSpec, toleration v13.Toleration) {
}

// ApplyPodSpec modifies a PodSpec to use this runtime.
func (t RuntimeType) ApplyPodSpec(podSpec *v13.PodSpec) {
func (t RuntimeType) ApplyPodSpec(np *NodePool, podSpec *v13.PodSpec) {
switch t {
case RuntimeTypeGVisor:
podSpec.RuntimeClassName = proto.String(gvisorRuntimeClass)
podSpec.NodeSelector[NodepoolRuntimeKey] = string(RuntimeTypeGVisor)
addToleration(podSpec, v13.Toleration{
Key: "nvidia.com/gpu",
Operator: v13.TolerationOpExists,
})
if np.numAccelerators > 0 {
addToleration(podSpec, v13.Toleration{
Key: "nvidia.com/gpu",
Operator: v13.TolerationOpExists,
})
}
case RuntimeTypeUnsandboxed:
podSpec.RuntimeClassName = nil
podSpec.Tolerations = append(podSpec.Tolerations, v13.Toleration{
Expand Down
2 changes: 1 addition & 1 deletion test/kubernetes/testcluster/testcluster.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -655,7 +655,7 @@ func (t *TestCluster) applyCommonPodConfigurations(ctx context.Context, np *Node
applyRuntime = t.testNodepoolRuntimeOverride
}
// Apply the runtime we've chosen, whether by override or autodetection.
applyRuntime.ApplyPodSpec(podSpec)
applyRuntime.ApplyPodSpec(np, podSpec)

// If the nodepool has accelerators, copy the number of them as a node
// selector option.
Expand Down