Skip to content

Improve plug-and-play: making enable_aks = True by default #1107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ThibaultDECO wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Improve plug-and-play: making enable_aks = True by default #1107

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions meridian/model/spec.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,7 @@ class ModelSpec:
algorithm to select an optimal number of knots for running the model
instead of the default 1 for national models and n_times for geo models.
If this is set to `True` and the `knots` arg is provided, then an error
will be raised. Default: `False`.
will be raised. Default: `True`.
"""

prior: prior_distribution.PriorDistribution = dataclasses.field(
Expand All @@ -242,7 +242,7 @@ class ModelSpec:
control_population_scaling_id: np.ndarray | None = None
non_media_population_scaling_id: np.ndarray | None = None
adstock_decay_spec: str | Mapping[str, str] = constants.GEOMETRIC_DECAY
enable_aks: bool = False
enable_aks: bool = True

def __post_init__(self):
# Validate media_effects_dist.
Expand Down