Skip to content

Fixing error in rounding + doc typo #1128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ThibaultDECO wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fixing error in rounding + doc typo #1128

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions meridian/analysis/optimizer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ class OptimizationGrid:
start_date: The start date of the optimization period.
end_date: The end date of the optimization period.
gtol: Float indicating the acceptable relative error for the budget used in
the grid setup. The budget is rounded by `10*n`, where `n` is the smallest
the grid setup. The budget is rounded by `10**n`, where `n` is the smallest
integer such that `(budget - rounded_budget)` is less than or equal to
`(budget * gtol)`.
round_factor: The round factor used for the optimization grid.
Expand Down Expand Up @@ -1442,7 +1442,7 @@ def optimize(
used for flexible budget scenarios. The budget is constrained to when
the marginal ROI of the total spend hits `target_mroi`.
gtol: Float indicating the acceptable relative error for the budget used
in the grid setup. The budget will be rounded by `10*n`, where `n` is
in the grid setup. The budget will be rounded by `10**n`, where `n` is
the smallest integer such that `(budget - rounded_budget)` is less than
or equal to `(budget * gtol)`. `gtol` must be less than 1.
use_optimal_frequency: If `True`, uses `optimal_frequency` calculated by
Expand Down Expand Up @@ -1978,7 +1978,7 @@ def create_optimization_grid(
Consider using `InputData.get_paid_channels_argument_builder()` to
construct this argument.
gtol: Float indicating the acceptable relative error for the budget used
in the grid setup. The budget will be rounded by `10*n`, where `n` is
in the grid setup. The budget will be rounded by `10**n`, where `n` is
the smallest integer such that `(budget - rounded_budget)` is less than
or equal to `(budget * gtol)`. `gtol` must be less than 1.
use_optimal_frequency: Boolean. Whether optimal frequency was used.
Expand Down Expand Up @@ -2753,7 +2753,7 @@ def get_round_factor(budget: float, gtol: float) -> int:
Args:
budget: Float number for total advertising budget.
gtol: Float indicating the acceptable relative error for the budget used in
the grid setup. The budget will be rounded by `10*n`, where `n` is the
the grid setup. The budget will be rounded by `10**n`, where `n` is the
smallest int such that `(budget - rounded_budget) <= (budget * gtol)`.
`gtol` must be less than 1.

Expand All @@ -2768,7 +2768,7 @@ def get_round_factor(budget: float, gtol: float) -> int:
elif tolerance < 1.0:
return 0
else:
return -int(math.log10(tolerance)) - 1
return -int(math.log10(tolerance))


def _validate_pct_of_spend(
Expand Down