Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove nested transactions from domain (un)locking #2658

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gbrodman
Copy link
Collaborator

@gbrodman gbrodman commented Jan 30, 2025

This change is Reviewable

@gbrodman gbrodman requested a review from jianglai January 30, 2025 20:17
Copy link
Collaborator

@jianglai jianglai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 2 files at r1, all commit messages.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @gbrodman)


core/src/main/java/google/registry/tools/LockOrUnlockDomainCommand.java line 82 at r1 (raw file):

    ImmutableSet.Builder<String> successfulDomainsBuilder = new ImmutableSet.Builder<>();
    ImmutableMap.Builder<String, String> failedDomainsToReasons = new ImmutableMap.Builder<>();
    partition(getDomains(), BATCH_SIZE)

Is there a concern about removing batching here?

Copy link
Collaborator Author

@gbrodman gbrodman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @jianglai)


core/src/main/java/google/registry/tools/LockOrUnlockDomainCommand.java line 82 at r1 (raw file):

Previously, jianglai (Lai Jiang) wrote…

Is there a concern about removing batching here?

nah, we never do these in bulk anyway and this is just making it have a batch size of 1

@gbrodman gbrodman added the kokoro:force-run Force a Kokoro build. label Jan 30, 2025
@domain-registry-eng domain-registry-eng removed the kokoro:force-run Force a Kokoro build. label Jan 30, 2025
Copy link
Collaborator

@jianglai jianglai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 2 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @gbrodman)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants