Veles custom extractor for aws access key

[alessandro-Doyensec]

This PR introduces a custom extractor, AWS Access Keys, by enabling support for running a veles.Detector on specific files.

Using the convert.FromVelesDetectorWithRequire it's possible to create a plugin which actually implements both:

• filesystem.Extractor
• veles.Detector

This results into a single plugin for the osv-scalibr cli users which once created, is duplicated as:

• One veles.Detector: treated like all other detectors and added to veles.NewDetectionEngine (ref: https://github.com/doyensec/osv-scalibr/blob/e13727f50b999d1a1fe037f27f38f0b1f253bec4/extractor/filesystem/secrets/convert/convert.go#L107).
• One filesystem.Extractor (ref: https://github.com/doyensec/osv-scalibr/blob/e13727f50b999d1a1fe037f27f38f0b1f253bec4/extractor/filesystem/secrets/convert/convert.go#L108)

[alessandro-Doyensec]

Note

Initially (ref: 1306cce) I attempted a different approach: creating a new filesystem.Extractor with a completely separate Name. However, that introduced a usability issue: the user would have had to enable or disable two plugins for the same secret.

[alessandro-Doyensec]

Hello @erikvarga

All discussions should be resolved now.

Thank you for the support!

[alessandro-Doyensec]

Hello @erikvarga I noticed the failing action and I added 462f138 to address the issue.

It looks like the secrets were returned in a different order on Windows, which caused the failure.

[erikvarga]

Hello @erikvarga I noticed the failing action and I added 462f138 to address the issue.

It looks like the secrets were returned in a different order on Windows, which caused the failure.

Ah sorry I didn't see this yesterday. We caught this during the internal merge process and ended up adding a similar order ignore clause to the test.