Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: group DSA and its CVEs together #1262

Merged
merged 2 commits into from
Sep 23, 2024
Merged

Conversation

hogo6002
Copy link
Contributor

For container scanning, we should only display DSA results and hide their related CVEs.

  • Add DSA's related CVEs to the same group.
  • Sort the group IDs with the DSA first. (DSA is more important than CVE, and one DSA contains multiple CVEs)
  • Don't print CVE records when there is a DSA (this reduces noise in container scanning results).

@codecov-commenter
Copy link

codecov-commenter commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.32%. Comparing base (1856add) to head (710aa96).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1262      +/-   ##
==========================================
+ Coverage   68.29%   68.32%   +0.03%     
==========================================
  Files         175      175              
  Lines       16764    16776      +12     
==========================================
+ Hits        11449    11463      +14     
+ Misses       4682     4681       -1     
+ Partials      633      632       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@another-rex another-rex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Added some comments.

pkg/grouper/grouper_models.go Show resolved Hide resolved
pkg/grouper/grouper.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@another-rex another-rex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hogo6002 hogo6002 merged commit 75a5eab into google:main Sep 23, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants