Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Follow revive rules across the repo #1263

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

another-rex
Copy link
Collaborator

Followup to #1259

Resolves #1257

@codecov-commenter
Copy link

codecov-commenter commented Sep 20, 2024

Codecov Report

Attention: Patch coverage is 74.19355% with 8 lines in your changes missing coverage. Please review.

Project coverage is 68.29%. Comparing base (5704806) to head (6e65903).

Files with missing lines Patch % Lines
internal/image/extractor.go 57.14% 3 Missing ⚠️
pkg/reporter/void_reporter.go 40.00% 3 Missing ⚠️
pkg/lockfile/osv-vuln-results.go 0.00% 1 Missing ⚠️
pkg/osvscanner/osvscanner.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1263      +/-   ##
==========================================
- Coverage   68.30%   68.29%   -0.02%     
==========================================
  Files         175      175              
  Lines       16764    16764              
==========================================
- Hits        11451    11449       -2     
- Misses       4681     4682       +1     
- Partials      632      633       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@another-rex another-rex merged commit 46ab63d into google:main Sep 20, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reenable revive golangci-lints
5 participants