Update to v2025.1, bump version, and use errors #155
Merged
+112
−69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 2, 2025
filnet
reviewed
Mar 2, 2025
shaderc-rs/src/lib.rs
Outdated
| Ok(()) | ||
| } | ||
| Error::InternalError(ref r) => { | ||
| if r.is_empty() { | ||
| write!(f, "internal error") | ||
| } else { | ||
| write!(f, "internal error: {r}") | ||
| write!(f, "internal error: {}", r) |
There was a problem hiding this comment.
these changes will make clippy sad
There was a problem hiding this comment.
@filnet thank you for pointing out! I've gone through these including format! etc. I hope it is better now. Please LMK if anything else would make it more suitable!
antiagainst
requested changes
Mar 9, 2025
|
@antiagainst thank you very much for the review! Indeed, making uppercase without trailing dot makes things look more consistent. I've also merged upstream to here! If there's any other update that'd make this PR more suitable, PLMK and I'll adjust! Thank you! |
antiagainst
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, thank you very much for creating these bindings! Both
*-sysand*-rscrates have good organization, which makes things convenient to develop.While iterating some Python bindings based on these Rust bindings (this https://github.com/mehmetoguzderin/shaderc-rs-py repo), the lack of version bumps and updated dependencies started causing problems due to missing enums, etc. This PR aims to address those. This update also fixes some typos and uses errors rather than options, potentially addressing the following issue, too: #154 (also the request for submodule version update in #150 issue)
I can update the PR and adjust it to make it more suitable if needed. Thank you for your consideration!