Feat/depth mesh normview transform#204
Merged
dli7319 merged 9 commits intogoogle:mainfrom Mar 27, 2026
Merged
Conversation
dli7319
requested changes
Mar 23, 2026
Fixes google#93. Three changes: 1. Apply normDepthBufferFromNormView transform in getDepth() and getVertex() so view-space coordinates map correctly to depth buffer coordinates when matchDepthView is false. 2. Add depthMeshUpdateFps option to allow the expensive geometry rebuild to run at a lower frame rate than the depth data. The pose is still updated every frame for smooth tracking. 3. Expose normDepthBufferFromNormViewMatrices for external code that needs the view-to-depth coordinate mapping.
Adds vitest + jsdom as test infrastructure. Includes tests for the normDepthBufferFromNormView coordinate transform in getDepth() and getVertex(), and for the depthMeshUpdateFps throttling behaviour.
salmanmkc
force-pushed
the
feat/depth-mesh-normview-transform
branch
from
7172bc5 to
0828659
Compare
salmanmkc
force-pushed
the
feat/depth-mesh-normview-transform
branch
from
dc97309 to
c366040
Compare
salmanmkc
force-pushed
the
feat/depth-mesh-normview-transform
branch
from
cd785e8 to
7931718
Compare
Contributor
Author
|
the latest dependabot packages, mixed with needing rebase, redid npm install but too many package lock json files, seems to be fine now using main's changes after rebase |
dli7319
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #93
Three changes: applies
normDepthBufferFromNormViewingetDepth()andgetVertex()so view-space coordinates map correctly to depth buffer space, adds depthMeshUpdateFps to decouple geometry rebuild rate from the render loop, and exposes the transform matrices for external use.Again, same as #203 and #202 I have added a test harness, which we can rebase off of later.
Test harness issue: #205