chore(x-goog-spanner-request-id): propagate reqId into exceptions plus prior code review suggestions #3922
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: m
odeke-em
force-pushed
the
x-goog-spanner-request-id-smaller-PR-updates-from-prior-review
branch
from
e20523b to
fa13ac5
Compare
olavloite
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
odeke-em
force-pushed
the
x-goog-spanner-request-id-smaller-PR-updates-from-prior-review
branch
from
fa13ac5 to
612fea8
Compare
|
Kindly help me re-run the bots @olavloite @rahul2393 @sakthivelmanii @harshachinta @surbhigarg92 |
odeke-em
force-pushed
the
x-goog-spanner-request-id-smaller-PR-updates-from-prior-review
branch
2 times, most recently
from
ac475a2 to
84f10fc
Compare
olavloite
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
odeke-em
force-pushed
the
x-goog-spanner-request-id-smaller-PR-updates-from-prior-review
branch
from
9de5ffc to
9752996
Compare
|
Kindly help run the bots again @olavloite @rahul2393. |
olavloite
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
…s prior code review suggestions This change propagates the associated request-id into encountered exceptions and also addresses some code review questions from PR googleapis#3900. While here added some updates for AbstractReadContext.java and ResumableStreamIterator.java to set grounds for much smaller PRs in which we shall wholesomely test the changes. Curved out of PR googleapis#3898 and PR googleapis#3915
odeke-em
force-pushed
the
x-goog-spanner-request-id-smaller-PR-updates-from-prior-review
branch
from
ead88fe to
6261a92
Compare
odeke-em
commented
Jun 26, 2025
google-cloud-spanner/src/main/java/com/google/cloud/spanner/SessionImpl.java
Show resolved
Hide resolved
sakthivelmanii
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
…-from-prior-review
|
@sakthivelmanii @rahul2393 @olavloite, kindly help me re-run the bots as I rebased from main with the latest merge and all prior tests has passed. |
olavloite
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
olavloite
approved these changes
Jun 27, 2025
google-cloud-spanner/src/main/java/com/google/cloud/spanner/SpannerException.java
Show resolved
Hide resolved
sakthivelmanii
approved these changes
Jun 27, 2025
odeke-em
deleted the
x-goog-spanner-request-id-smaller-PR-updates-from-prior-review
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change propagates the associated request-id into encountered exceptions and also addresses some code review questions from PR #3900. While here added some updates for AbstractReadContext.java and ResumableStreamIterator.java to set grounds for much smaller PRs in which we shall wholesomely test the changes.
Curved out of PR #3898 and PR #3915