Skip to content

Commit

Permalink
updated type checks to be isinstance checks per linter
Browse files Browse the repository at this point in the history
  • Loading branch information
chalmerlowe committed Aug 15, 2023
1 parent 8493c3a commit 7991e4d
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion google/cloud/bigquery/client.py
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,7 @@ def __init__(
bq_host = _get_bigquery_host()
kw_args["api_endpoint"] = bq_host if bq_host != _DEFAULT_HOST else None
if client_options:
if type(client_options) == dict:
if isinstance(client_options, dict):
client_options = google.api_core.client_options.from_dict(
client_options
)
Expand Down
2 changes: 1 addition & 1 deletion google/cloud/bigquery/job/query.py
Original file line number Diff line number Diff line change
Expand Up @@ -1382,7 +1382,7 @@ def _reload_query_results(
# Our system does not natively handle that and instead expects
# either none or a numeric value. If passed a Python object, convert to
# None.
if type(self._done_timeout) == object: # pragma: NO COVER
if isinstance(self._done_timeout, object): # pragma: NO COVER
self._done_timeout = None

if self._done_timeout is not None:
Expand Down

0 comments on commit 7991e4d

Please sign in to comment.