This repository has been archived by the owner on Mar 13, 2018. It is now read-only.
Paper tab listens for down event and explicitly fires ripple down/up. #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| */ | ||
| downAction: function(e) { | ||
| if (!this.noink && !this.parentElement.noink) { | ||
| var ripple = this.shadowRoot.querySelector('paper-ripple'); |
There was a problem hiding this comment.
Shadow descendants with ID attributes are accessible on this.$: this.$.ink.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request allows us to interact with developer's tab content as a developer would expect removing the
pointer-event: nonecurrently applied and explicitly calling the ripple's down/upAction with the current event.Specifically, this allows us (me) to use html anchor tags within the paper-tabs' content to take advantage of the browser's natural navigation system (and avoid an unnecessary click listener just to update window.location). I'm using it, and thought I would share.