Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade Gradle and dependencies #802

Merged
merged 10 commits into from
Jan 30, 2025
Merged

chore: upgrade Gradle and dependencies #802

merged 10 commits into from
Jan 30, 2025

Conversation

dkhawk
Copy link
Contributor

@dkhawk dkhawk commented Jan 24, 2025

Android Gradle Plugin to 8.8.0
Android Maps Utils to 3.10.0
Activity to 1.10.0
Navigation Fragment to 2.8.5
Places to 4.1.0
and View Binding to 8.8.0

Also updated Gradle to 8.10.2 and Kotlin to 2.1.0.

Address some lint problems.

Thank you for opening a Pull Request!


Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

Android Gradle Plugin to 8.8.0
Android Maps Utils to 3.10.0
Activity to 1.10.0
Navigation Fragment to 2.8.5
Places to 4.1.0
and View Binding to 8.8.0

Also updated Gradle to 8.10.2 and Kotlin to 2.1.0.

Address some lint problems.
@dkhawk dkhawk requested a review from kikoso January 24, 2025 20:04
* fix: Improved place parser
updates build files to build.gradle.kts
improves api key configuration error detection
uses secrets plugin
Copy link

snippet-bot bot commented Jan 24, 2025

Here is the summary of changes.

You are about to add 1 region tag.
You are about to delete 2 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

Android Gradle Plugin to 8.8.0
Android Maps Utils to 3.10.0
Activity to 1.10.0
Navigation Fragment to 2.8.5
Places to 4.1.0
and View Binding to 8.8.0

Also updated Gradle to 8.10.2 and Kotlin to 2.1.0.

Address some lint problems.
updates build files to build.gradle.kts
improves api key configuration error detection
uses secrets plugin
@dkhawk dkhawk requested a review from jeff-bowman January 27, 2025 20:54
@kikoso
Copy link
Collaborator

kikoso commented Jan 28, 2025

Re-running failed jobs, something seems to be introducing an issue.

@kikoso
Copy link
Collaborator

kikoso commented Jan 29, 2025

@dkhawk , the build was failing because it is somehow not working with the new default Ubuntu runner (24.04 instead of 22.04, see this link) Setting explicitly 22.04 works.

The error we are getting is when the debug keystore is going to be created: java.io.IOException: Unable to create debug keystore in /home/runner/.config/.android because it is not writable.

This is not on our side. I would suggest keeping 22.04 explicitly until we find a fix to work with 24.04

Everything else in the PR LGTM, feel free to merge :)

Copy link
Collaborator

@kikoso kikoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dkhawk dkhawk merged commit 92a1ce1 into main Jan 30, 2025
10 checks passed
@dkhawk dkhawk deleted the update-versions branch January 30, 2025 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants