-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade Gradle and dependencies #802
Conversation
Android Gradle Plugin to 8.8.0 Android Maps Utils to 3.10.0 Activity to 1.10.0 Navigation Fragment to 2.8.5 Places to 4.1.0 and View Binding to 8.8.0 Also updated Gradle to 8.10.2 and Kotlin to 2.1.0. Address some lint problems.
* fix: Improved place parser
updates build files to build.gradle.kts improves api key configuration error detection uses secrets plugin
Here is the summary of changes. You are about to add 1 region tag.
You are about to delete 2 region tags.
This comment is generated by snippet-bot.
|
Android Gradle Plugin to 8.8.0 Android Maps Utils to 3.10.0 Activity to 1.10.0 Navigation Fragment to 2.8.5 Places to 4.1.0 and View Binding to 8.8.0 Also updated Gradle to 8.10.2 and Kotlin to 2.1.0. Address some lint problems.
updates build files to build.gradle.kts improves api key configuration error detection uses secrets plugin
…to update-versions
Re-running failed jobs, something seems to be introducing an issue. |
@dkhawk , the build was failing because it is somehow not working with the new default Ubuntu runner (24.04 instead of 22.04, see this link) Setting explicitly 22.04 works. The error we are getting is when the debug keystore is going to be created: This is not on our side. I would suggest keeping 22.04 explicitly until we find a fix to work with 24.04 Everything else in the PR LGTM, feel free to merge :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Android Gradle Plugin to 8.8.0
Android Maps Utils to 3.10.0
Activity to 1.10.0
Navigation Fragment to 2.8.5
Places to 4.1.0
and View Binding to 8.8.0
Also updated Gradle to 8.10.2 and Kotlin to 2.1.0.
Address some lint problems.
Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕