Skip to content

Exception handling in response for potential error #517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Exception handling in response for potential error #517

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion googlemaps/directions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
"""Performs requests to the Google Maps Directions API."""

from googlemaps import convert
from googlemaps.exceptions import ApiError


def directions(client, origin, destination,
Expand Down Expand Up @@ -150,4 +151,15 @@ def directions(client, origin, destination,
if traffic_model:
params["traffic_model"] = traffic_model

return client._request("/maps/api/directions/json", params).get("routes", [])
# Make the API request
response = client._request("/maps/api/directions/json", params)

# Check if the API request was successful
if response.get("status") == "OK":
return response.get("routes", [])
elif response.get("error_message"):
# Handle specific error message returned by the API
raise ApiError(response.get("error_message"))
else:
# Handle generic API error
raise ApiError("Unknown error occurred during API request")