Camera2 API support #921
Open
Camera2 API support #921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 3499113.
…iew multiple times) by using coroutine blocking mechanism.
… Main thread only to avoid any ambiguous behaviour and some code cleanup.
…mera2 API source because older Camera API source is required for devices where Camera2 API not supported at hardware level. - Merged additional code base required for Camera2 API within original codebase (e.g. Camera2SourcePreview into CameraSourcePreview). - Added picture size preference over preview size in GraphicOverlay for Camera2 API support.
…agment and pass it from currently used Camera source when opening it.
…ch required yuv to nv21 conversion before it can be used as bitmap. Introduced ConfirmedObjectInfo class to fix the issue of accessing bitmap from frame data after it has been closed. It create a distinction between detected object and confirmed object. Also, started using this class at places where confirmed object required. Moved imageData property from DetectedObjectInfo to ConfirmedObjectInfo. Also, fix a bitmap variable assignment issue in DetectedObjectInfo class.
…ge preference over previewSize if exists for Camera2APISource & GraphicOverlay to fix the issue in processing frames (could be due to higher resolution) by MLKit ObjectDetector. - Revert the applicationId changes done for debugging purpose.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The major change of this pull request contains the Camera2 API support for the sample.