Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(calendar): Readded multiple groups and added blocked groups #456

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

lwcorp
Copy link
Contributor

@lwcorp lwcorp commented Apr 15, 2024

Description

  1. Undid the removal of the support for multiple groups (why did you allow this person's PR just so they fix formatting?)
  2. Made the multiple groups and get all members functions to use each other to avoid duplicated code
  3. Added support for avoiding blocked groups (e.g. external ones)
  4. Fixed to prevent script crash when any event has no summary
  5. Simplified both functions' code
  6. Fixed spelling while at it (hope it's okay to avoid an extra PR just to put fix in the title instead of feat)

Is it been tested?

  • Development testing done

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have performed a peer-reviewed with team member(s)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

1. Undid the removal of the support for multiple groups (why did you allow this person's PR just so they fix formatting?)
2. Made the multiple groups and get all members functions to use each other to avoid duplicated code
3. Added support for avoiding blocked groups (e.g. external ones)
4. Simplified both functions' code
@lwcorp
Copy link
Contributor Author

lwcorp commented Apr 15, 2024

Please note the failed tests failed Google's own original code, not my additions.

Copy link

@baveer baveer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code works great for single group, nested groups and multiple groups (which was broken by someone else). I have no idea why these tests failed, several calendars are up and running in my environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants