Skip to content

cl: TestTestgo: fix #2775#2781

Merged
xushiwei merged 1 commit into
goplus:mainfrom
xushiwei:q
Jun 21, 2026
Merged

cl: TestTestgo: fix #2775#2781
xushiwei merged 1 commit into
goplus:mainfrom
xushiwei:q

Conversation

@xushiwei

Copy link
Copy Markdown
Member

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enables the TestTestgo test suite, updates its target directory argument, and adds a corresponding test file cl/_testgo/types/out.go to verify basic Go types. Additionally, the github.com/goplus/gogen dependency is upgraded from v1.23.2 to v1.23.3. There are no review comments, and I have no additional feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@xushiwei xushiwei merged commit d03e9b3 into goplus:main Jun 21, 2026
9 checks passed
@codecov

codecov Bot commented Jun 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.12%. Comparing base (d9fe5c5) to head (b558754).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2781   +/-   ##
=======================================
  Coverage   94.12%   94.12%           
=======================================
  Files          32       32           
  Lines       10166    10166           
=======================================
  Hits         9569     9569           
  Misses        427      427           
  Partials      170      170           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fennoai fennoai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix is correct: re-enabling TestTestgo (removing the _ prefix) and providing the matching golden file out.go is the right approach to close #2775. The sel="" change is consistent with every other sibling test (TestTestxgo, TestTestc, TestTestpy), all of which use the same empty-string convention to cover all subdirectories under their test dir.

One thing to confirm before merging: since TestTestgo was previously disabled, out.go has never been exercised by CI. Please confirm it was produced by actually running go test -run TestTestgo ./cl/ locally against gogen v1.23.3 (i.e. auto-generated, not hand-written). If gogen's exact formatting—import order, var grouping, spacing—differs even slightly from the file, the test will fail on first CI run.

The go.sum changes look correct: only the two gogen hash entries were swapped.

Comment thread cl/_testgo/types/out.go
"math/cmplx"
)

var ToBe bool = false

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The source in.xgo groups these three vars in a single var (...) block, but out.go expands them into separate var declarations. Please confirm this matches what gogen v1.23.3 actually emits when compiling in.xgo — the golden file will fail CI if any formatting detail (grouping, spacing, blank lines) differs from the real compiler output.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant