-
Notifications
You must be signed in to change notification settings - Fork 194
Add Droid CLI agent support #111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tommy-ca
wants to merge
5
commits into
gotalab:main
Choose a base branch
from
tommy-ca:feature/droid-cli
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `tools/cc-sdd/templates/agents/droid/droids/spec-quick.md:1-4` is structured like a slash command (only `description`, `allowed-tools`, `argument-hint`) instead of a sub-droid manifest (`name`, `tools`, `model`, `color`). Every other droid (for example `spec-design` in the same folder) declares a `name` and capability list so the Task runtime knows which subagent to invoke. Without that metadata the Factory Droid runtime cannot register the “spec-quick” helper, so any attempt to run it headlessly (`droid exec spec-quick` or a future `Task(subagent_type="...")`) will never resolve the file. - Even if you add the missing front‑matter, the body of `spec-quick.md` (lines 18‑32) still assumes slash-command semantics: it parses `$ARGUMENTS`, manipulates TodoWrite, prompts the user interactively, and shells out to `/kiro:spec-*` via `SlashCommand`. Sub-droids invoked through `Task(...)` get a structured prompt (see `spec-design.md:1-37`) and do not have `$ARGUMENTS`, TodoWrite, or the SlashCommand tool in their sandbox. As written, the “sub-droid” can’t be executed by the Task runner—it needs to be rewritten to accept Task input (feature name, mode flags, file patterns) and perform the orchestration itself, or the file should be removed to avoid shipping a broken automation. - Documentation still tells users that Factory AI Droid is “planned”, so nobody installing from README will know this agent now ships. The English README (`tools/cc-sdd/README.md:120-133`) and both localized READMEs (`README_ja.md:120-133`, `README_zh-TW.md:121-129`) all mark Droid as “📅 Planned/予定/規劃中` instead of “✅ Full” and don’t mention the new manifest. That’s inconsistent with the code/tests you just added and will confuse people comparing release notes to actual behavior. **Open Questions** - Was the intent to expose a Task-addressable `spec-quick` sub-droid, or should this command only exist in `.factory/commands`? Clarifying that will determine whether the broken file should be fixed or discarded. **Verification** - `npm test` (tools/cc-sdd)
- Removed the unused Factory Droid sub-agent file (`tools/cc-sdd/templates/agents/droid/droids/spec-quick.md`) so only Task-ready droids remain in the library. - Updated the manifest regression test to reflect the new footprint; it now just asserts the `/spec-quick` command is emitted (`tools/cc-sdd/test/realManifestDroidSpecQuick.test.ts:41-58`). **Command/Sub-agent Mapping Snapshot** - Commands (directories: `.../droid/commands` vs `.../claude-code/commands`): all eleven core `/kiro:*` commands align one-to-one (spec-init, requirements, design, tasks, impl, status, steering, steering-custom, validate-gap/design/impl). Droid additionally ships `spec-quick.md`, which does not exist for Claude Code; keeping this documented helps set expectations while you work on cross-agent parity. - Sub-agents (directories: `.../droid/droids` vs `.../claude-code-agent/agents`): after deleting the spec-quick helper, every remaining file has an exact Claude counterpart (spec-requirements/design/tasks/impl, steering/steering-custom, validate-gap/design/impl). That gives you a clean mapping table for future docs or automation scripts. | Domain | Droid Artifact | Claude Counterpart | Notes | |--------|----------------|--------------------|-------| | Commands | `.factory/commands/spec-init.md` (etc.) | `.claude/commands/spec-init.md` (etc.) | Parity across 11 commands; only Droid has `spec-quick.md`. | | Sub-agents | `.factory/droids/spec-design.md`, ... | `.claude/agents/kiro/spec-design.md`, ... | Now 1:1 after dropping spec-quick helper. | | Manifest | `templates/manifests/droid.json` | (none; Claude uses `claude-code.json`) | Manifest already copies commands + droids + settings; keep crosswalk doc handy for users switching agents. | **Outstanding Findings** - Documentation still tells users that Factory Droid support is “planned” (`tools/cc-sdd/README.md:120-133`, `tools/cc-sdd/README_ja.md:120-133`, `tools/cc-sdd/README_zh-TW.md:121-129`). Please update these tables (and any related text) so the repo advertises the new agent correctly. - The `/spec-quick` slash command remains Droid-only. If you intend Claude Code (or others) to keep using its own spec-quick workflow, note that explicitly in docs; otherwise plan the remaining parity work (e.g., either adding spec-quick to other agents or documenting why it’s Droid-exclusive). **Tests** - `npm test -- realManifestDroidSpecQuick.test.ts` **Next Steps** 1. Update the READMEs (EN/JA/ZH-TW) and any marketing copy so Factory Droid shows as fully supported and links to `DROID.md`. 2. Decide whether `/spec-quick` should stay Droid-exclusive; if so, add a short note to `DROID.md` and the README tables, otherwise plan the Claude Code command parity. 3. Produce the final mapping artifact (table or doc) for internal reference so future contributors know every Droid file’s Claude counterpart.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Testing