refactor: extract rename_single_skill_dir helper #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add rename_single_skill_dir() to internal/github.py - Consolidate duplicate single-skill directory rename logic - Update add.py and update.py to use shared helper 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
There was a problem hiding this comment.
Pull request overview
This PR successfully extracts duplicate directory renaming logic into a reusable helper function. When GitHub repositories contain a single skill, the extracted temporary directory needs to be renamed to match the skill name from SKILL.md frontmatter. This logic was duplicated in both add.py and update.py and has been consolidated into rename_single_skill_dir().
Key Changes:
- Extracted
rename_single_skill_dir()helper function ininternal/github.py - Simplified both
add.pyandupdate.pyto use the shared helper - Maintained backward-compatible behavior with early-return optimization
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/skillport/modules/skills/internal/github.py | Added rename_single_skill_dir() helper function that renames extracted GitHub directories to match single skill names |
| src/skillport/modules/skills/internal/init.py | Exported new rename_single_skill_dir function from internal module |
| src/skillport/modules/skills/public/add.py | Refactored to use rename_single_skill_dir() helper, removing duplicate logic |
| src/skillport/modules/skills/public/update.py | Refactored to use rename_single_skill_dir() helper, removing duplicate logic |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
rename_single_skill_dir()helper to consolidate duplicate logicadd.pyandupdate.pyfor handling single-skill GitHub reposChanges
rename_single_skill_dir()tointernal/github.pyinternal/__init__.pyadd.pyandupdate.pyto use shared helperTest plan
🤖 Generated with Claude Code