Skip to content

fix: use Path.name for cross-platform directory extraction #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gotalab merged 1 commit into from
Dec 21, 2025
+1 −1
Merged

fix: use Path.name for cross-platform directory extraction #52

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/skillport/modules/skills/internal/validation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ def validate_skill_record(
description = skill.get("description", "")
lines = skill.get("lines", 0)
path = skill.get("path", "")
dir_name = path.rsplit("/", 1)[-1] if path else ""
dir_name = Path(path).name if path else ""
Copy link

Copilot AI Dec 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The existing test suite has comprehensive coverage for the validate_skill_record function, but lacks test cases for Windows-style paths. Consider adding a test case that validates the name-directory matching works correctly with Windows paths like 'C:\skills\test-skill' to ensure the cross-platform fix is tested.

Copilot uses AI. Check for mistakes.

# A1/A2: Key existence checks (only when meta is provided)
if meta is not None:
Expand Down