Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add connection close repro attempt #1293

Merged
merged 5 commits into from
Jan 21, 2024
Merged

Conversation

ernado
Copy link
Member

@ernado ernado commented Jan 21, 2024

Warning

Currently I'm unable to reproduce the issue.

Ref: #1030, #760, #1110, #1021

@ernado ernado added the help wanted Extra attention is needed label Jan 21, 2024
Copy link

codecov bot commented Jan 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bca12ed) 69.49% compared to head (f621c72) 69.31%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1293      +/-   ##
==========================================
- Coverage   69.49%   69.31%   -0.18%     
==========================================
  Files         441      441              
  Lines       21249    21262      +13     
==========================================
- Hits        14766    14738      -28     
- Misses       5553     5597      +44     
+ Partials      930      927       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ernado ernado marked this pull request as ready for review January 21, 2024 12:33
@ernado
Copy link
Member Author

ernado commented Jan 21, 2024

It looks like SOMETIMES this can be reproduced.
I'm adjusting some error handling and default backoff to reduce (or probably eliminate) probability of a hangup.

@ernado ernado merged commit 7e622dd into main Jan 21, 2024
14 checks passed
@ernado ernado deleted the teat/connclose-reproduce branch January 21, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant