feat: potential SLA breach batch - #571
Merged
Merged
Conversation
ahmadnaufal
reviewed
Jul 6, 2026
…e SLA breach domain types
ahmadnaufal
reviewed
Jul 6, 2026
ahmadnaufal
left a comment
There was a problem hiding this comment.
few more comments, other than that LGTM
ahmadnaufal
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Batch and consolidate potential SLA breach alerts per team
Summary
IdentifyPotentialSLABreachnow accepts repeatedproject_namesandlabel_groupsin one request instead of requiring a fan-out of multiple separate per-project/per-label calls, each of which triggered its own alert — teams previously got fragmented, noisy notifications instead of one clear summary.computeBreaches) and batch consolidation (IdentifySLABreachesBatch), which aggregates every project/label-group combo into exactly one alert per team, structured as project → SLA group → target job → causing jobs, tolerant of individual combo failures.PotentialSLABreachAttrs, AlertManager adapter, Siren template); per-group severity was considered but dropped after team discussion in favor of a single request-level severity, keeping the request/response shape simpler.dev/README.md, including several pre-existing local dev-setup bugs found and fixed along the way (missing required server config causing crash loops, a hardcoded gRPC port mismatch, a plugin-discovery path bug, and an Airflow Helm chart version pin that had gone stale).Test plan
go build ./...go vet ./core/scheduler/... ./ext/notify/...core/scheduler/service,core/scheduler/handler/v1beta1,ext/notify/alertmanagerKubernetesPodOperatorexecution, real dependency chain) — confirmed correct multi-level lineage attribution and real alert delivery to Siren rendering through the updated template