This repository was archived by the owner on Sep 21, 2020. It is now read-only.
GPII-3391: New dataloader for aws #198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's nothing special about the dataloader anymore, as it lives as part of universal and not individual project. Dataloader itself is documented at https://github.com/GPII/universal/blob/master/documentation/DataLoader.md
Contributor
|
LGTM |
mrtyler
reviewed
Oct 31, 2018
Contributor
mrtyler
left a comment
mrtyler
left a comment
There was a problem hiding this comment.
LGTM.
Thanks for the links to related work, the data management/upgrade plan, and the doc cleanups!
Contributor
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings new dataloader to AWS infra as well. I've verified state of AWS database and it's consistent with GCP (at least the entries relevant for this change). Steps to deploy are same as the ones for gcp part (see #163 for details), note: the couchdb pod is called just couchdb-0.
This PR also removes docs about dataloader, as there's nothing special about the dataloader anymore, it now lives as part of universal and not an individual project. Dataloader itself is documented at https://github.com/GPII/universal/blob/master/documentation/DataLoader.md and does not require any special treatment from the infra point of view.