This repository was archived by the owner on Sep 21, 2020. It is now read-only.
GPII-3192 Modify gpii-infra's use of gpii-dataloader #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed the CLEAR_INDEX flag so that the database is not always cleared when the dataloader is run.
Contributor
|
LGTM |
Contributor
|
This is fine for me, as soon as the GPII/universal#626 is ready to be merged. |
Contributor
|
Looks good to me. |
Merged upstream master GPII branch into GPII-3192.
7 tasks
Contributor
|
I'm closing this in favor of #163. See that PR for details. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mrtyler @amatas This is a change needed for deploying the gpii-dataloader. In this case, we don't clear the entire data base when setting it up; hence, the CLEAR_INDEX is not set to true.