fix(gql_code_builder): isBuilder detection for tristate #493
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dan Printzell <[email protected]>
Vild
force-pushed
the
fix_tristate_builder
branch
from
51fbe5b to
bfe7a2b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not 100% sure if this logic is fully correct.
But it fixes the code generator so it outputs correct code within the deserialize function when tristate is enabled.
Context:
It didn't recognize that graphql type
scalar MyScalarneeded to be built via a Builder, and could not be directly assigned.So I got a bunch of "GMyScalarBuilder is not assignable with GMyScalar`.
I tried to add tests for this fix,, but gave up as it kept never generating the
GMyScalartype.