feat(gql_dio_link): support per-request timeouts via DioLinkTimeoutCo… - #522
Open
ljanecek wants to merge 1 commit into
Open
feat(gql_dio_link): support per-request timeouts via DioLinkTimeoutCo…#522ljanecek wants to merge 1 commit into
ljanecek wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
DioLinkreads onlyDioLinkCancelTokenContextEntryandHttpLinkHeadersfrom the request context — there is no way to set Dio's
sendTimeout/receiveTimeoutfor a single operation. Long-runningoperations (e.g. a mutation waiting ~20 s for a device to acknowledge a
command) then require a second Dio/GraphQLClient instance, or smuggling a
marker header through
HttpLinkHeadersand converting it in an interceptor.What
Adds
DioLinkTimeoutContextEntry({sendTimeout, receiveTimeout}), followingthe same pattern as
DioLinkCancelTokenContextEntry.nullfields keep theclient-wide timeouts. Deliberately limited to timeouts (instead of a whole
dio.Options) so the link keeps control ofresponseTypeand headers —happy to generalize if you'd prefer.