adding some metrics to metrics-sql #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
April 18, 2016 13:20
gquintana
requested changes
Aug 29, 2017
| @@ -3,6 +3,15 @@ | |||
| This a Yammer|Codahale|Dropwizard Metrics extension to instrument JDBC resources | |||
| and measure SQL execution times. | |||
|
|
|||
|
|
|||
| ## NOTE: this fork adds the following: | |||
| 1. add metrics on borrow connection, implemented in DataSourceProxyHandler. | |||
There was a problem hiding this comment.
This should be in the PR description not in the readme.
|
|
||
| /* | ||
| * #%L | ||
| * Metrics SQL |
There was a problem hiding this comment.
What is the change here in license?
| @@ -48,6 +48,8 @@ protected Object invoke(MethodInvocation<T> delegatingMethodInvocation) throws T | |||
| result = close(delegatingMethodInvocation); | |||
| } else if (methodName.equals("execute") || methodName.equals("executeQuery") || methodName.equals("executeUpdate")) { | |||
| result = execute(delegatingMethodInvocation); | |||
| } else if (methodName.equals("getResultSet")){ | |||
| result = getResultSet(delegatingMethodInvocation); | |||
There was a problem hiding this comment.
Interesting change, I like it.
| return connection; | ||
|
|
||
| Timer.Context failedBorrowContext = null; | ||
| Timer.Context borrowContext = null; |
There was a problem hiding this comment.
I don't understand the difference between your borrow context timer and the original connection life timer.
| /** | ||
| * {@inheritDoc} | ||
| */ | ||
| public Timer.Context startBorrowConnectionTimer(String databaseName) { |
There was a problem hiding this comment.
Please integrate the new MetricsNamingStrategy API, it's cleaner.
| @@ -170,6 +170,11 @@ public Properties getProperties() { | |||
| public Class<? extends MetricRegistryHolder> getRegistryHolderClass() { | |||
| return getProperty("metrics_registry_holder", Class.class, StaticMetricRegistryHolder.class); | |||
| } | |||
|
|
|||
| public Class<? extends JdbcProxyFactory> getJdbcProxyFactoryClass() { | |||
| return getProperty("metrics_jdbc_proxy_factory", Class.class, JdbcProxyFactory.class); | |||
There was a problem hiding this comment.
Why do you need such an extension point? Why do you to replace the JdbcProxyFactory
| /** | ||
| * Created on 4/17/16. | ||
| */ | ||
| public class DriverWrapper implements java.sql.Driver { |
|
|
||
|
|
||
|
|
||
| private static class ConnectionProxyHandlerOnlyConnection extends ConnectionProxyHandler{ |
There was a problem hiding this comment.
What the difference with original connectionproxyhandler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.