Skip to content

[CI] Enable assertions #871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: default
Choose a base branch
from
Open

[CI] Enable assertions #871

wants to merge 1 commit into from

Conversation

zakkak
Copy link
Collaborator

@zakkak zakkak commented Aug 25, 2025

Opening as draft till upstream graal updates to JDK 26+12, as it currently fails with:

 java.lang.NoSuchMethodError: java.lang.StringCoding.implEncodeISOArray([BI[BII)
	at jdk.graal.compiler/jdk.graal.compiler.nodes.graphbuilderconf.InvocationPlugins$Checks.checkResolvable(InvocationPlugins.java:1119)
	at jdk.graal.compiler/jdk.graal.compiler.nodes.graphbuilderconf.InvocationPlugins.register(InvocationPlugins.java:765)
	at org.graalvm.nativeimage.builder/com.oracle.svm.hosted.substitute.SubstitutionInvocationPlugins.register(SubstitutionInvocationPlugins.java:84)
	at jdk.graal.compiler/jdk.graal.compiler.nodes.graphbuilderconf.InvocationPlugins$Registration.register(InvocationPlugins.java:243)
	at jdk.graal.compiler/jdk.graal.compiler.replacements.StandardGraphBuilderPlugins.registerStringCodingPlugins(StandardGraphBuilderPlugins.java:2624)
	at jdk.graal.compiler/jdk.graal.compiler.replacements.StandardGraphBuilderPlugins.registerInvocationPlugins(StandardGraphBuilderPlugins.java:287)
	at org.graalvm.nativeimage.builder/com.oracle.svm.hosted.NativeImageGenerator.registerGraphBuilderPlugins(NativeImageGenerator.java:1492)
	at org.graalvm.nativeimage.builder/com.oracle.svm.hosted.NativeImageGenerator.initializeBigBang(NativeImageGenerator.java:1314)
	at org.graalvm.nativeimage.builder/com.oracle.svm.hosted.NativeImageGenerator.setupNativeImage(NativeImageGenerator.java:1111)
	at org.graalvm.nativeimage.builder/com.oracle.svm.hosted.NativeImageGenerator.doRun(NativeImageGenerator.java:567)
	at org.graalvm.nativeimage.builder/com.oracle.svm.hosted.NativeImageGenerator.run(NativeImageGenerator.java:534)
	at org.graalvm.nativeimage.builder/com.oracle.svm.hosted.NativeImageGeneratorRunner.buildImage(NativeImageGeneratorRunner.java:548)
	at org.graalvm.nativeimage.builder/com.oracle.svm.hosted.NativeImageGeneratorRunner.build(NativeImageGeneratorRunner.java:761)
	at org.graalvm.nativeimage.builder/com.oracle.svm.hosted.NativeImageGeneratorRunner.start(NativeImageGeneratorRunner.java:163)
	at org.graalvm.nativeimage.builder/com.oracle.svm.hosted.NativeImageGeneratorRunner.main(NativeImageGeneratorRunner.java:111)

due to openjdk/jdk@655dc51#diff-42f5711b7bc39a45a6e647f8e09e69eab24556a282f272017d9b33b42911ee35

Closes #846

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Aug 25, 2025
@zakkak zakkak force-pushed the 2025-08-25-enable-assertions branch from 1836bd9 to e487009 Compare August 25, 2025 11:55
@zakkak zakkak added the testing CI and testing related issues and PRs label Aug 25, 2025
jerboaa
jerboaa approved these changes Aug 25, 2025
View reviewed changes
Copy link
Collaborator

@jerboaa jerboaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM provided CI is fine with this.

@zakkak
Copy link
Collaborator Author

zakkak commented Aug 26, 2025

Depends on: oracle#12042

@zakkak zakkak marked this pull request as ready for review August 28, 2025 13:12
@zakkak zakkak force-pushed the 2025-08-25-enable-assertions branch from e487009 to c4b0c0d Compare September 16, 2025 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerboaa jerboaa jerboaa approved these changes

Assignees
No one assigned
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement. testing CI and testing related issues and PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable assertions in CI runs
2 participants
@zakkak @jerboaa