-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --arch global option to support arm64 macOS via Rosetta2 #245
Conversation
Hello Ergys Dona, thanks for contributing a PR to our project! We use the Oracle Contributor Agreement to make the copyright of contributions clear. We don't have a record of you having signed this yet, based on your email address ergys -(dot)- dona -(at)- gmail -(dot)- com. You can sign it at that link. If you think you've already signed it, please comment below and we'll check. |
One of my organisations here at GitHub (HexHive at EPFL - my employer, https://github.com/HexHive) has signed the CLA. |
8e63c0c
to
91d7a51
Compare
Hello Ergys Dona, thanks for contributing a PR to our project! We use the Oracle Contributor Agreement to make the copyright of contributions clear. We don't have a record of you having signed this yet, based on your email address ergys -(dot)- dona -(at)- epfl -(dot)- ch. You can sign it at that link. If you think you've already signed it, please comment below and we'll check. |
As already stated above, one of my organisations here at GitHub (HexHive at EPFL - my employer, https://github.com/HexHive) has signed the CLA, so I have been told that it should not be necessary that I sign it individually. |
This change is too intrusive and risky to be made as an automatic feature. How about adding an |
Ergys Dona has signed the Oracle Contributor Agreement (based on email address ergys -(dot)- dona -(at)- epfl -(dot)- ch) so can contribute to this repository. |
There are currently no restrictions in the architecture that can be specified, except from the list of allowed options. |
We don't want to introduce a new concept of "effective arch" and now all callers now need to think about the diff between |
To be honest the only reason for this change is to display the real underlying architecture in the introduced warning message. We could instead just introduce an "internal" method |
15fa6b7
to
1b38eae
Compare
That looks much better. |
LGTM |
mx.py
Outdated
@@ -581,6 +581,7 @@ def __init__(self, parents=None): | |||
"projects and store it in the given <file>. If <file> is 'default', the compilation database will " | |||
"be stored in the parent directory of the repository containing the primary suite. This option " | |||
"can also be configured using the MX_COMPDB environment variable. Use --compdb none to disable.") | |||
self.add_argument('--arch', action='store', dest='arch', help='force use the specified architecture') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
force use the -> force use of the
This PR now looks good to merge. Can you please rebase it on master and squash it to a single commit. |
737eb08
to
5580cfd
Compare
Allows to specify a custom architecture target. Useful for arm64-based Apple computers, until all used native libraries are released for arm64. Example usage: mx --arch amd64 ...
5580cfd
to
cdc91e8
Compare
Right now,
mx
refuses to run on M1 Macs (#232).Allow to specify a custom architecture target. Useful for arm64-based Apple computers, until all used native libraries are released for arm64.
Example usage:
mx --arch amd64 ...