Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SBOM: Ensure 'java-version' is persisted to post-run phase #151

Merged
merged 1 commit into from
Mar 3, 2025

Conversation

rudsberg
Copy link
Contributor

@rudsberg rudsberg commented Mar 3, 2025

The SBOM integration tests emitted this warning in the post-run phase

Warning: Error: setUpSBOMSupport must be called before processSBOM

Example here.

This PR resolves this issue. The problem was that the post-run phase of the SBOM feature read a variable that was not persisted from the main phase. The solution is to use the core.saveState and core.getState API.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Mar 3, 2025
@fniephaus fniephaus self-assigned this Mar 3, 2025
Copy link
Member

@fniephaus fniephaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@fniephaus fniephaus merged commit 3ca6fc3 into graalvm:main Mar 3, 2025
114 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants