[newchem-cpp] transcribe calc_grain_size_increment_species_1d#507
Open
ChristopherBignamini wants to merge 65 commits intograckle-project:newchem-cppfrom
Conversation
Essentially, this type holds pointers to the various injection pathway fields in the order that is implicitly assumed throughout the codebase. This change helps simplify make_consistent and it will also simplify `calc_grain_size_increment_1d` (once transcribed). Longer term, I have a plan that will let use dispose of this ``InjectPathFieldPack`` type (but, we need to make a few changes before we get to that).
Introduce the start_idx and stop_idx members to the struct
Use the start_idx and stop_idx members to simplify make_consistent
…t for-loops PART 2
…t for-loops PART 3
…ize_increment_1d.hpp
I was expecting this to cause gold-standard drift (but that doesn't seem to be the case)
for more information, see https://pre-commit.ci
…tps://github.com/ChristopherBignamini/grackle into newchem-cpp_transcribe_calc_all_tdust_gasgr_1d_g
for more information, see https://pre-commit.ci
…_increment_1d' into newchem-cpp_transcribe_calc_all_tdust_gasgr_1d_g
…tps://github.com/ChristopherBignamini/grackle into newchem-cpp_transcribe_calc_all_tdust_gasgr_1d_g
for more information, see https://pre-commit.ci
…ion interface/name
ChristopherBignamini
changed the title
…transcribe_calc_grain_size_increment_species_1d
ChristopherBignamini
changed the title
Contributor
Author
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
…s_1d' of https://github.com/ChristopherBignamini/grackle into newchem-cpp_transcribe_calc_grain_size_increment_species_1d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR requires some additional work to fix a numerical issue which occurs in a call with j=k=0 and first iteration of i-loop (j=k=1 in Fortran), when coef3 is equal to zero. I temporarily added a line to skip the cubic equation solution in this case and we need to find a final fix.