[newchem-cpp] Introduce Installation Tests#517
Open
mabruzzo wants to merge 45 commits intograckle-project:newchem-cppfrom
Open
[newchem-cpp] Introduce Installation Tests#517mabruzzo wants to merge 45 commits intograckle-project:newchem-cppfrom
mabruzzo wants to merge 45 commits intograckle-project:newchem-cppfrom
Conversation
The relevant test got moved to the core-lib suite a while back
The `--prefix` case wasn't being properly handled
I forgot that the order of arguments definitely matters
Essentially, problems started cropping up because toolchain::m wasn't properly declared within the CMake Package Config file. I worked around the issue by getting rid of the target
mabruzzo
added
testing
…fferent docker images and parameters
Contributor
|
I'm not sure I know how to review this effectively. Don't redo anything. I think we just need to discuss it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To be reviewed after #513 has been merged
This PR introduces some "installation tests". These serve as a check on the build-system and on the documentation. The tests are driven by the
tests/install-tests/installtest.pytest harness.(I'm sorry the PR is so big -- it just kept growing and growing)
I wrote up a lot of documentation on this topic. At this point, I need to move on (I've spent a lot of time trying to polish this PR). If during your review the PR you find it to be too incoherent, just let me know. I can try to take another pass.