[newchem-cpp] Reorganize Tabulated Routines#533
Open
mabruzzo wants to merge 50 commits intograckle-project:newchem-cppfrom
Open
[newchem-cpp] Reorganize Tabulated Routines#533mabruzzo wants to merge 50 commits intograckle-project:newchem-cppfrom
mabruzzo wants to merge 50 commits intograckle-project:newchem-cppfrom
Conversation
This switches to using GRIMPL_NAMESPACE_DECL and puts all the helper function into the namespace
The result is definitely not bitwise identical, but that's not going to make tests fail (since the logic is not tested)
This was referenced Apr 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should be reviewed after #529 has been merged.
This has been a long time coming. Essentially, this PR shifts all of the routines that are primarily associated with cloudy heating/cooling tables and shifts them into a newly created
tabulatedsubdirectory. I'm not 100% convinced this is the optimal way to organize the code, but I think its an improvement for now and we can change later.While I did this, I dropped the trailing
_gfrom all relevant function names and modernized the way we declare namespaces.The commits are very atomic, so it may be easier to review this commit-by-commit