Test more DV plugin versions #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bigdaz
force-pushed
the
dd/test-plugin-versions
branch
2 times, most recently
from
0ccb8ab
to
17d0033
Compare
erichaagdev
requested changes
Nov 8, 2024
erichaagdev
approved these changes
Nov 8, 2024
bigdaz
force-pushed
the
dd/test-plugin-versions
branch
from
392b4c3
to
55309fc
Compare
Previously, our test coverage for injection of the DV plugin was limited to the latest DV plugin. The only exception was testing v3.16.2, but even then we failed to test setting the DV URL, capture fingerprints, etc. With this change, we now test running the init-script with different DV versions to inject, ensuring our script continues to support injection of older plugin versions (which may be required if the DV server environment is out of date).
The log messages are used to test init-script functionality. This change moves the 'Enforce URL' logging so that it is only emitted when DV URL is actually forced.
The init-script must be able to apply configuration to a Gradle build that already has the DV plugin applied, and must not error regardless of the DV plugin version applied. Previously, we only tested against Gradle builds using the latest DV plugin, and GE plugin v3.16.2. With this change, we now test running the init-script on projects with many different DV versions applied.
- Avoid CCUD tests where plugins are not compatible - Temporarily ignore tests that demonstrate issue with enforceUrl and GE plugin < 3.2
Several "successful" CCUD scenarios were logging errors from build scan publishing. We now check that no exceptions are logged when applying the init-script.
bigdaz
force-pushed
the
dd/test-plugin-versions
branch
from
55309fc
to
ede45fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends coverage of the init-script to include more plugin versions.
These tests exposed an issue when enforcing the DV URL on a project that already
applies the
com.gradle.build-scan:[3.17,3.18.1]plugin.As such, these versions are excluded from testing for now.
We do not test early versions of the GE/BuildScan plugins, since the mock server protocol
appears to have changed. This will require fixing to expand the coverage further.