Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to aws-sdk-go-v2 #491

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Migrate to aws-sdk-go-v2 #491

wants to merge 3 commits into from

Conversation

njvrzm
Copy link
Contributor

@njvrzm njvrzm commented Jan 16, 2025

This manages athena's direct use of aws-sdk-go-v2 and updates it to use our fork of the athenadriver package, which has also been updated.

@njvrzm njvrzm requested a review from a team as a code owner January 16, 2025 13:25
@njvrzm njvrzm requested review from iwysiu and idastambuk January 16, 2025 13:25
@njvrzm njvrzm self-assigned this Jan 16, 2025
@njvrzm njvrzm force-pushed the njvrzm/aws-sdk-v2 branch from 9f0773a to 7ec6f68 Compare January 22, 2025 10:22
Copy link
Contributor

@idastambuk idastambuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested manually, looks good

@njvrzm njvrzm requested a review from idastambuk February 14, 2025 15:47
@njvrzm
Copy link
Contributor Author

njvrzm commented Feb 14, 2025

Reupping the review request because I've migrated this to use the new v2 auth mechanism of grafana-aws-sdk.

@njvrzm njvrzm force-pushed the njvrzm/aws-sdk-v2 branch from fec25dc to e237944 Compare March 18, 2025 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants