-
Notifications
You must be signed in to change notification settings - Fork 2
feat(config): Add custom docs and feature flag #159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Bundle Size ChangesHello! 👋 This comment was generated by a Github Action to help you and reviewers understand the impact of your PR on frontend bundle sizes. Whenever this PR is updated, this comment will update to reflect the latest changes.
View detailed bundle informationAdded
Removed
Bigger
Smaller No assets were smaller View module informationAdded
Removed No modules were removed Bigger
Smaller
|
Thinking about this implementation a bit and stepping back. I don't believe we think this is how custom user provided docs will work so this is really just to provide alternative recommendations in the recommender. Would it be easier to just configure the recommender URL so you can just run a recommender with whatever configuration you like and have it recommend documentation in the way it would in production? |
Would it be easier to just configure the recommender URL so you can just run a recommender with whatever configuration you like and have it recommend documentation in the way it would in production? hmm this means you would have to host a second recommender somewhere that grafana cloud has access to. we could have a dev recommender that people could use for testing but then we would need another build workflow to make sure those changes are deployed. In this case we are just using the same simplfied logic as the static links recommender uses within the plugin which i think is easier overall. I think asking OSS and customers to host their own recommender will just be somthing else they need to support. where as this feels more like our git integration where you just select the repos you want to include |
Playwright test results
|
This PR adds a new tab to the configuration page called custom docs. This will lay the ground work for allowing customers to eventually add their own docs to the plugin. For now it acts as a development tool so we can add test repos with interactive tutorials and bypass adding them to the recommender.
I have added this feature under a feature flag which is enabled by default when you deploy locally using npm run server. Otherwise, the feature will be blocked by default.
To test:
Set up a custom docs repo. My recommendation for testing is just to use: https://github.com/grafana/interactive-tutorials