Support alternate outputPath #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@zackman0010 thank you for the addition! I had this in an earlier iteration but it must have gotten lost. I will take care of getting this into rollup. much appreciated. feel free to merge. I will do a release this week. |
eskirk
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using certain Webpack configurations, particularly the one used by Create-React-App, compiled JS files and their associated mappings are not stored in the base
buildfolder. Instead, they're stored in a nestedbuild/static/jsfolder. As thereaddirSyncfunction used by the Webpack plugin is not recursive, this means the JS files will not be found using the default folder. This PR adds the ability to set the outputPath in the plugin configuration.I did not touch the Rollup plugin, as I do not use that system and am not familiar enough with it to make changes or even know if it needs the same change.