Skip to content

Support alternate outputPath#13

Merged
eskirk merged 1 commit into
grafana:mainfrom
zackman0010:main
Jun 25, 2024
Merged

Support alternate outputPath#13
eskirk merged 1 commit into
grafana:mainfrom
zackman0010:main

Conversation

@zackman0010

@zackman0010 zackman0010 commented Jun 24, 2024

Copy link
Copy Markdown
Contributor

When using certain Webpack configurations, particularly the one used by Create-React-App, compiled JS files and their associated mappings are not stored in the base build folder. Instead, they're stored in a nested build/static/js folder. As the readdirSync function used by the Webpack plugin is not recursive, this means the JS files will not be found using the default folder. This PR adds the ability to set the outputPath in the plugin configuration.

I did not touch the Rollup plugin, as I do not use that system and am not familiar enough with it to make changes or even know if it needs the same change.

@CLAassistant

CLAassistant commented Jun 24, 2024

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@eskirk

eskirk commented Jun 24, 2024

Copy link
Copy Markdown
Collaborator

@zackman0010 thank you for the addition! I had this in an earlier iteration but it must have gotten lost. I will take care of getting this into rollup. much appreciated.

feel free to merge. I will do a release this week.

@eskirk
eskirk merged commit 935083b into grafana:main Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants